Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Conversation

@mayurkale22
Copy link
Member

No description provided.

@mayurkale22
Copy link
Member Author

@rghetia any idea why build is failing?

@rghetia
Copy link
Contributor

rghetia commented Mar 24, 2020

@rghetia any idea why build is failing?

C:\projects\opencensus-java\examples\src\main\java\io\opencensus\examples\grpc\helloworld\HelloWorldClient.java:60: error: method usePlaintext in class ManagedChannelBuilder<T> cannot be applied to given types;
            .usePlaintext(true)
            ^
  required: no arguments
  found: boolean
  reason: actual and formal argument lists differ in length
  where T is a type-variable:
    T extends ManagedChannelBuilder<T> declared in class ManagedChannelBuilder
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error

@mayurkale22 mayurkale22 force-pushed the bump-document-version branch from 1ba844d to a77e6ce Compare March 26, 2020 03:58
@codecov-io
Copy link

codecov-io commented Mar 26, 2020

Codecov Report

Merging #2028 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2028      +/-   ##
============================================
- Coverage     83.06%   83.04%   -0.02%     
+ Complexity     2251     2250       -1     
============================================
  Files           319      319              
  Lines         10529    10529              
  Branches       1048     1048              
============================================
- Hits           8746     8744       -2     
- Misses         1446     1447       +1     
- Partials        337      338       +1
Impacted Files Coverage Δ Complexity Δ
...pencensus/implcore/trace/RecordEventsSpanImpl.java 92.34% <0%> (-1.03%) 49% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc5780...f3039de. Read the comment docs.

@mayurkale22 mayurkale22 force-pushed the bump-document-version branch from a77e6ce to 389f275 Compare March 26, 2020 04:08
@mayurkale22 mayurkale22 force-pushed the bump-document-version branch from 389f275 to f3039de Compare March 26, 2020 23:14
@mayurkale22
Copy link
Member Author

@rghetia any idea why build is failing?

C:\projects\opencensus-java\examples\src\main\java\io\opencensus\examples\grpc\helloworld\HelloWorldClient.java:60: error: method usePlaintext in class ManagedChannelBuilder<T> cannot be applied to given types;
            .usePlaintext(true)
            ^
  required: no arguments
  found: boolean
  reason: actual and formal argument lists differ in length
  where T is a type-variable:
    T extends ManagedChannelBuilder<T> declared in class ManagedChannelBuilder
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error

Since grpc v1.26.0, the deprecated API ManagedChannelBuilder.usePlaintext(boolean) is removed. I have removed removed arguments, hopefully build should pass now.

@rghetia rghetia merged commit 8af8543 into census-instrumentation:master Mar 26, 2020
@mayurkale22 mayurkale22 deleted the bump-document-version branch March 26, 2020 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants